Skip to content

Patch refresh for 50418#8964

Open
audrasjb wants to merge 1 commit intoWordPress:trunkfrom
audrasjb:50418-2020-inline-image
Open

Patch refresh for 50418#8964
audrasjb wants to merge 1 commit intoWordPress:trunkfrom
audrasjb:50418-2020-inline-image

Conversation

@audrasjb
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props audrasjb.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Comment on lines +3604 to 3605
.entry-content p img,
.entry-content li img {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ticket needed the 'changes-requested' keyword.

  • The specificity of .entry-content p img could be too high.
  • Centered images added with Classic Editor need display: block to center properly.
  • I closed ticket 57912 to address inline images in the Verse block at the same time.

One option with lower specificity:

Suggested change
.entry-content p img,
.entry-content li img {
html :where(.entry-content p img:not(.aligncenter)),
:where(.wp-block-verse) img,
.entry-content li img {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants